-
-
Notifications
You must be signed in to change notification settings - Fork 579
Add grid snapping to graph imports/exports; improve layer panel drag into/between insertion; better preserve graph space on reordering #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1abe8d
to
86dbb28
Compare
A couple more edge cases when snapping needs to get engaged:
|
Keavon
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge after you fix that edge case.
One more very minor, harmless edge case I found: when you open a demo artwork, then open the graph, its export is in the wrong place before you pan for the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the default positioning system when moving nodes in the layer panel, mostly by ensuring that node gap positioning is correctly maintained. Each layer is the height of that layer plus the height to the next layer below. Fixes all edge cases when moving layers or different groups of selected layers to any other location. Also improves the previewing system and import/export edges
Todo: