Skip to content

Add grid snapping to graph imports/exports; improve layer panel drag into/between insertion; better preserve graph space on reordering #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 11, 2024

Conversation

adamgerhant
Copy link
Collaborator

@adamgerhant adamgerhant commented Aug 7, 2024

Reworks the default positioning system when moving nodes in the layer panel, mostly by ensuring that node gap positioning is correctly maintained. Each layer is the height of that layer plus the height to the next layer below. Fixes all edge cases when moving layers or different groups of selected layers to any other location. Also improves the previewing system and import/export edges

Todo:

  • Create space when moving layers to different stacks

@Keavon
Copy link
Member

Keavon commented Aug 10, 2024

A couple more edge cases when snapping needs to get engaged:

  • Scrolling with your mouse's horizontal mouse scroll wheel (or Shift+vertical scroll wheel)
  • Scrolling with the horizontal scroll bar

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after you fix that edge case.

@Keavon Keavon changed the title Improve positioning when moving nodes in the Layers panel Add grid snapping to graph imports/exports; improve layer panel drag into/between insertion; better preserve graph space on reordering Aug 10, 2024
@Keavon
Copy link
Member

Keavon commented Aug 10, 2024

One more very minor, harmless edge case I found: when you open a demo artwork, then open the graph, its export is in the wrong place before you pan for the first time.

@Keavon Keavon merged commit 193f757 into master Aug 11, 2024
2 checks passed
@Keavon Keavon deleted the layer-panel-positioning branch August 11, 2024 00:30
@adamgerhant adamgerhant modified the milestone: Sprint 40 Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants