Upgrade heroku stack #1768
Merged
Upgrade heroku stack #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do we want to do this at the same time as getting the Rails upgrade live, or finish that first for easier investigation of issues? |
cesy
approved these changes
Jan 2, 2019
Member
cesy
left a comment
cesy
left a comment
There was a problem hiding this comment.
Happy for it to be merged once we're clear on deployment order of all the big changes.
Member
Author
|
I'm happy to do both at once. Prod and staging are out of sync, so I'd like to test on heroku-18 on staging, and know we will be deploying the same to prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @eoinkelly's work in ODNZSL/nzsl-online#480
The version of the heroku stack is old on both staging and prod. Prod uses cedar-14 and staging uses heroku-16
by moving this into heroku's
app.jsonfile, we will be able to both upgrade it from a PR, and also keep staging and prod in sync.This also adds enough info for someone else to quickly deploy their own version of growstuff.org on heroku if they want to.