-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Optional moment.js Part 2 #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martijnrusschen
merged 14 commits into
Hacker0x01:master
from
prayerslayer:feature/optional-moment-part2
Oct 3, 2017
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
28ec2db
Remove moment from calendar_test
5aefa8e
Remove moment from date_utils_test
fd3b614
Refactor repetition of key data
46060b5
Remove moment from datepicker_test
c0c1c44
Remove moment from day_test
bd87677
Remove moment from exclude_time_period_test
fbf542b
Remove moment from exclude_times_test
052994a
Remove moment from month_dropdown_test
2b66274
Remove moment from month_test
170ea32
Remove moment from timezone_date_picker
9ae533f
Remove moment from week_test
6068298
Remove moment from year_dropdown_test
f046042
Fix missed instances of moment calls in datepicker_test
7b82f65
Ignore .DS_Store files (MacOS)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
node_modules | ||
.sass-cache | ||
npm-debug.log | ||
.DS_Store | ||
.idea | ||
.vscode | ||
dist | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a bit cleaner to use separate functions to parse a date and to get the current date. We can leave that for later though, since
moment()
did serve both purposes too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, had exactly the same thought :)