New functionality to adjust day when changing week, month or year #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prop 'adjustDateOnChange' offers a possibility to update the date respectively on month switch or year select. Keyboard support.
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 86.25% 85.22% -1.03%
==========================================
Files 13 13
Lines 851 873 +22
Branches 142 148 +6
==========================================
+ Hits 734 744 +10
- Misses 32 40 +8
- Partials 85 89 +4
Continue to review full report at Codecov.
|
|
Can you add some tests to cover your new behaviour? We want to avoid breaking this behaviour next time someone touches this code. |
Squar89
pushed a commit
to Squar89/react-datepicker2
that referenced
this pull request
Apr 10, 2019
…cker0x01#1123) * Change date on month switch and year select * Change date on month switch and year select Prop 'adjustDateOnChange' offers a possibility to update the date respectively on month switch or year select. Keyboard support. * Error corrections. * Added tests for 'adjustDateOnChange' * Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propose the following added functionality to improve the user experience for the datepicker component.
If the new property adjustDateOnChange is set to true, the date will automatically change when the current month is altered via the arrow controls or a different year is selected via the year dropdown. Also, all changes through keyboard shortcuts are supported. If adjustDateOnChange is undefined or false, the behaviour is unchanged from the current release versions.
The following example illustrates the new behaviour:
The same methodology applies if the year is changed.