Add an includeTimes prop #1216
Merged
Add an includeTimes prop #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyscript-ridecell
changed the title
jennyscript-ridecell
force-pushed
the
feature/add-include-times
branch
2 times, most recently
from
05b8e33 to
62e6ff7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
+ Coverage 86.19% 86.73% +0.54%
==========================================
Files 15 15
Lines 1014 1018 +4
Branches 165 165
==========================================
+ Hits 874 883 +9
+ Misses 42 38 -4
+ Partials 98 97 -1
Continue to review full report at Codecov.
|
This option is the same idea as "includeDates" but applies to the time select. Only times that are included in the "includeDates" list and also match up with settings like "timeIntervals" will be included. All other times are disabled. This uses the same helper function as "excludeTimes" for implementation.
jennyscript-ridecell
force-pushed
the
feature/add-include-times
branch
from
62e6ff7 to
6a4193c
Compare
|
Is there any additional work needed here before it can be merged? I see a few PRs have been merged by @mnikkane since I submitted this one, so please provide feedback if you'd like to see anything else here. I'd really like to use the datepicker on my company's application and we need this feature. Also, I've found some bugs I'd be happy to submit PRs for after this one. |
|
Looks good, thanks! |
Squar89
pushed a commit
to Squar89/react-datepicker2
that referenced
this pull request
Apr 10, 2019
…add-include-times Add an includeTimes prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is the same idea as "includeDates" but applies to the time select. Only times that are included in the "includeTimes" list and also match up with settings like "timeIntervals" will be included. All other times are disabled.
This uses the same helper function as "excludeTimes" for implementation.