Skip to content

Adding clickable week number feature. #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2017

Conversation

sentient06
Copy link

Example:

<DatePicker
    showWeekNumbers
    onWeekSelect={(firstDayOfTheWeek, weekNumber) => {
        alert(firstDayOfTheWeek.format() + ', ' + weekNumber)
    }}
/>

@codecov-io
Copy link

codecov-io commented Jul 10, 2017

Codecov Report

Merging #936 into master will decrease coverage by 0.6%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   85.99%   85.38%   -0.61%     
==========================================
  Files          12       12              
  Lines         614      616       +2     
  Branches      118      120       +2     
==========================================
- Hits          528      526       -2     
- Misses          3        6       +3     
- Partials       83       84       +1
Impacted Files Coverage Δ
src/datepicker.jsx 91.71% <ø> (ø) ⬆️
src/calendar.jsx 87.96% <ø> (-0.43%) ⬇️
src/month.jsx 81.81% <100%> (-0.8%) ⬇️
src/week_number.jsx 35.71% <28.57%> (+2.38%) ⬆️
src/week.jsx 73.33% <66.66%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad8de0...8c0f695. Read the comment docs.

@alex-shamshurin
Copy link
Contributor

Could you squash you commits into one-two and without merge commits?

@martijnrusschen
Copy link
Member

martijnrusschen commented Jul 11, 2017 via email

@sentient06
Copy link
Author

Should I create a new PR?

@martijnrusschen martijnrusschen merged commit 003cf69 into Hacker0x01:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants