Multidatabasecapability secondtry #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull upstream
As far as I can tell by now Qt really does not assume that running out of memory is a failure mode in a enviroment that their framework is supposed to run in.
with the old implementation there was a issue where you could really only use one database with CWF::SqlDatabaseStorage in you're application. This was due to the fact that CWF::SqlDatabaseStorage::getDatabase would always return the first database connection created on the executing thread. It would possibly ignore Configuration given to CWF::SqlDatabaseStorage which a user might not expect. This patch fixes that. It replaces the internal pointer to QSqldatabase with two maps. One maps the application-database-connection names to unique-database-connection-names. The second map maps unique-database-connection-names to pointers to QSqldatabase objects. Also logic was added to to return the correct database-connection as well as cleanup code when the thread would exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please check if your Pull Request fulfills the following requirements:
Pull Request Type
What kind of change does this Pull Request introduce?
What is the current behavior?
CWF::SqldatabaseStorage can only handle one database per application properly
Issue Number: N/A
What is the new behavior?
CWF::SqldatabaseStorage will handle more than database per application properly given they have different connection names
Does this Pull Request introduce a breaking change?
Other information
form more information see commit c8eb66b