Fix manually setting matrixIsModified for hands #5376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
approved these changes
Apr 21, 2022
Contributor
takahirox
left a comment
takahirox
left a comment
There was a problem hiding this comment.
Yes, it seems that we shouldn't directly set matrixIsModified. Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5373 , a regression caused by #5290.
This bug already existed but was being masked by matrix-auto-update. The root cause is the breaking of this rule from https://github.com/mozilla/hubs/blob/master/src/utils/threejs-world-update.js#L17
The hand poses ended up being applied to the identity matrix which breaks all sorts of things. This fixes the
track-posesystem so that this flag gets flipped properly. We should probably add a function to Object3D to make this less hacky. The actual side effect we want from thisapplyMatrix4is to call_handleMatrixModificationwhich handles flipping thematrixIsModifiedflag and correctly clearing the cached matrix. We could call this directly, but based on the name we sort of expect this to be an internal implementation detail. Will need to think more about what the right API is here.