Add dbtdoc-bucket-path annotation #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow that a timing, maybe it will fix this issue recently open :) #243 I will review you PR |
|
@IIBenII Great timing :) Thank you |
|
Stars are aligned to have issue and PR at 30mn interval |
IIBenII
requested changes
May 17, 2024
sqsp-rwatkins
force-pushed
the
rwatkins/add-dbtdoc-bucket-path-annotation
branch
from
30a9ac2 to
cf30e16
Compare
|
@IIBenII All done. Thanks for the quick review |
IIBenII
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to use this plugin but the path to the DBT docs in our GCS bucket does not conform to the expected path. I have a feeling that other people will encounter this limitation, especially since the expected path uses
kindwhich is a specific Backstage term.What
Adding an optional
dbtdoc-pathannotation that can be used in an entity'scatalog-infofile as part of the multi setup. This path will override the{kind}/{name}portion of the path.