Skip to content

Conversation

MaineC
Copy link
Member

@MaineC MaineC commented May 13, 2022

On reading the pattern I noticed that InnerSource here is still written inconsistently.

On reading the pattern I noticed that InnerSource here is still written inconsistently.
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the IS spelling.

Left one comment where I don't understand the formatting.

Also there are some issues that the markdownlinter complains about that need fixing.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spier
Copy link
Member

spier commented May 28, 2022

While this pattern still has some other issues, the PR already represents an improvement to the spelling of InnerSource and some other formatting fixes.

Therefore let's merge this and leave further improvements to future PRs.

@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels May 28, 2022
@spier spier merged commit b4d531c into main May 28, 2022
@spier spier deleted the casing branch May 28, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants