Skip to content

feat(praise-participants): SAP known instance teaser #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2024
Merged

feat(praise-participants): SAP known instance teaser #678

merged 2 commits into from
Apr 8, 2024

Conversation

michael-basil
Copy link
Contributor

@michael-basil michael-basil commented Apr 7, 2024 •
edited
Loading

@spier @dellagustin - Teaser proposal as requested from #672

@michael-basil michael-basil marked this pull request as ready for review April 7, 2024 20:17
@spier spier added 2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. labels Apr 8, 2024
spier
spier reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting changes similar to #679.

If you have happy with my suggestion you can integrate it, and then I can merge this PR later today.

@spier spier merged commit 4bbcc16 into InnerSourceCommons:main Apr 8, 2024
@michael-basil michael-basil deleted the patch-1 branch April 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spier spier spier approved these changes

@lenucksi lenucksi Awaiting requested review from lenucksi lenucksi is a code owner

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid NewMexicoKid is a code owner

@cewilliams cewilliams Awaiting requested review from cewilliams cewilliams is a code owner

@robtuley robtuley Awaiting requested review from robtuley robtuley is a code owner

@yuhattor yuhattor Awaiting requested review from yuhattor yuhattor is a code owner

Assignees

No one assigned

Labels

2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michael-basil @spier