Skip to content

Think there might be a typo on pg 12 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2021
Merged

Think there might be a typo on pg 12 #133

merged 2 commits into from
Jan 7, 2021

Conversation

SalimGangji
Copy link
Contributor

@SalimGangji SalimGangji commented Jan 7, 2021 •
edited
Loading

Think there is a typo on pg12, the text should say -p:PublishSingleFile=true instead of /p:PublishSingleFile=true

@SalimGangji
Think there might be a typo on pg 12
1f27c4b 
Think there is a typo on pg12, the text should say `-p:PublishSingleFile=true` instead of `\p:PublishSingleFile=true`
@SalimGangji
Merge pull request #1 from SalimGangji/SalimGangji-patch-1
acd5681 
Think there might be a typo on pg 12
@BenjaminMichaelis BenjaminMichaelis merged commit 7e4adda into IntelliTect:v8.0 Jan 7, 2021
@BenjaminMichaelis
Copy link
Member

BenjaminMichaelis commented Jan 7, 2021 •
edited
Loading

The change suggested from a /p: to a -p:
Both work, however the -p: is an improvement as it is more universal, not working only in windows
The change suggested in the errata will be updated in the manuscript

@SalimGangji
Copy link
Contributor Author

Awesome, thank you Benjamin 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SalimGangji @BenjaminMichaelis