Fix erroneous warnings v8 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
COsborn2
commented
Jul 3, 2019
COsborn2
commented
- Remove warnings from Chapters 06 on.
- Update Listing06.18, 06.19, 06.49, 08.04, 08.05. Manuscript updates to follow
Keboo
approved these changes
Jul 3, 2019
| @@ -8,16 +8,16 @@ public class Program | |||
| public static void Main() | |||
| { | |||
| string[] values; | |||
| Contact contact1, contact2 = null; | |||
| Contact contact = null; | |||
|
|
|||
| // ... | |||
|
|
|||
| // ERROR: Unable to call ColumnValues() directly | |||
There was a problem hiding this comment.
Suggested change
| // ERROR: Unable to call ColumnValues() directly | |
| // ERROR: Unable to call .ColumnValues directly |
| @@ -8,16 +8,16 @@ public class Program | |||
| public static void Main() | |||
| { | |||
| string[] values; | |||
| Contact contact1, contact2 = null; | |||
| Contact contact = null; | |||
|
|
|||
| // ... | |||
|
|
|||
| // ERROR: Unable to call ColumnValues() directly | |||
There was a problem hiding this comment.
Suggested change
| // ERROR: Unable to call ColumnValues() directly | |
| // ERROR: Unable to call .ColumnValues directly |
| @@ -2,6 +2,8 @@ | |||
| { | |||
| using System; | |||
| using System.IO; | |||
| // Program.Data should take some value in a complete implementation | |||
| #pragma warning disable CS0649 | |||
There was a problem hiding this comment.
Can we simply fix the warning with
private readonly WeakReference Data = new WeakReference();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.