Add tests chapter08 v8 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
Sep 2, 2019
| } | ||
|
|
||
| [TestMethod] | ||
| public void CompareTo_ObjLargerThanThis_Return1() |
There was a problem hiding this comment.
This test and the one above appear to have the same condition name. One should be renamed
Keboo
reviewed
Sep 2, 2019
Keboo
reviewed
Sep 2, 2019
| // Split the assigned value into | ||
| // first and last names | ||
| string[] names; | ||
| names = value.Split(new char[] { ' ' }); |
There was a problem hiding this comment.
Did the original not combine the declaration and assignment?
There was a problem hiding this comment.
It did not. I lifted the Name property from a previous listing. Other properties were not included in the listing so I didn't have to make a book update. So I can change the property to an override above as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.