Side by side diff shows only partially all deleted lines

[vendeeglobe]

This happens only occasionally within the side by side diff mode.

php-diff: v1.16
WackoWiki 6.0.7

[JBlond]

That is a css problem. @vendeeglobe Please inspect which WackoWiki css rule overrides the css rule from php-diff.

[vendeeglobe]

But then the missing lines should show up in the HTML and they are not.

I can provide other examples.

[DigiLive]

Can you provide sample texts, so we can use them at our systems?

[vendeeglobe]

The text files with the source text for each revision.

Example 1:
example-1_r136.txt
example-1_r138.txt

Example 2:
example-2_r45.txt
example-2_r50.txt

Examples can be use freely.
Here you can see that the same source is passed for both modes:
https://github.com/WackoWiki/wackowiki/blob/master/wacko/handler/page/diff.php#L336

[DigiLive]

Since commit c017af5, the string for the table rows of deleted lines are defined with the heredoc syntax at method SideBySide::generateTableRowsDelete().

The concatenation is accidentally dropped with this change, which results in only returning the last row instead of all deleted rows.

I'll fix this bug, update the tests, examples and readme file and make PR.

[DigiLive]

I've made a PR which is waiting on JBlond to be reviewed and merged.

[JBlond]

@vendeeglobe There is now a release for it.