Skip to content

make mul! fast if first arg is Adjoint, fix block size (#172) #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2021

Conversation

dlfivefifty
Copy link
Member

Fixes #172

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #173 (615e15b) into master (de2a314) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   91.13%   91.25%   +0.11%     
==========================================
  Files          15       14       -1     
  Lines        1230     1304      +74     
==========================================
+ Hits         1121     1190      +69     
- Misses        109      114       +5     
Impacted Files Coverage Δ
src/abstractblockarray.jl 94.36% <ø> (ø)
src/blockarray.jl 95.62% <ø> (ø)
src/blockbroadcast.jl 93.91% <ø> (ø)
src/blockdeque.jl 92.47% <ø> (ø)
src/blockindices.jl 77.98% <ø> (ø)
src/blocks.jl 95.65% <ø> (ø)
src/pseudo_blockarray.jl 84.33% <ø> (-1.10%) ⬇️
src/blockaxis.jl 96.58% <100.00%> (ø)
src/blocklinalg.jl 95.48% <100.00%> (+2.82%) ⬆️
src/show.jl 97.50% <100.00%> (+1.91%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2a314...615e15b. Read the comment docs.

@dlfivefifty
Copy link
Member Author

@antoine-levitt I'm planning to drop Julia v1.5 (the change in print is annoying to maintain support). Any problems with this?

@antoine-levitt
Copy link

Not for us (we already depend on 1.6)

@dlfivefifty dlfivefifty merged commit 4a7f782 into master Jun 19, 2021
@dlfivefifty dlfivefifty deleted the dl/fastmul! branch June 19, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing matmul specialization
2 participants