use CC.MAX_INLINE_COST instead of typemax(Int)

[simeonschaub]

as cost threshold for always_inline to avoid integer overflow

fix JuliaGPU/AMDGPU.jl#846

alternative to JuliaLang/julia#60121

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/src/interface.jl b/src/interface.jl
index 21ddcf5..e1edfec 100644
--- a/src/interface.jl
+++ b/src/interface.jl
@@ -324,7 +324,7 @@ function optimization_params(@nospecialize(job::CompilerJob))
     kwargs = NamedTuple()
 
     if job.config.always_inline
-        kwargs = (kwargs..., inline_cost_threshold=Int(CC.MAX_INLINE_COST))
+        kwargs = (kwargs..., inline_cost_threshold = Int(CC.MAX_INLINE_COST))
     end
 
     return CC.OptimizationParams(;kwargs...)
diff --git a/test/gcn.jl b/test/gcn.jl
index 95641a4..c6e470c 100644
--- a/test/gcn.jl
+++ b/test/gcn.jl
@@ -37,12 +37,12 @@ end
     end
 end
 
-@testset "https://github.com/JuliaGPU/AMDGPU.jl/issues/846" begin
-    ir, rt = GCN.code_typed((Tuple{Tuple{Val{4}}, Tuple{Float32}},); always_inline=true) do t
-        t[1]
-    end |> only
-    @test rt == Tuple{Val{4}}
-end
+        @testset "https://github.com/JuliaGPU/AMDGPU.jl/issues/846" begin
+            ir, rt = GCN.code_typed((Tuple{Tuple{Val{4}}, Tuple{Float32}},); always_inline = true) do t
+                t[1]
+            end |> only
+            @test rt == Tuple{Val{4}}
+        end
 
 end
 

[maleadt]

Does this fix #527 ?

[simeonschaub]

Not 100% sure, JuliaLang/julia#51599 (comment) makes it sound like it wouldn't cover all cases. @aviatesk, do we eventually need a better solution for this?

[aviatesk]

Yeah, I think we need something like JuliaLang/julia#48257 as a complete fix.