Unaliasing and short-circuiting in copytrito!
#1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
=======================================
Coverage 92.03% 92.04%
=======================================
Files 34 34
Lines 15499 15505 +6
=======================================
+ Hits 14265 14271 +6
Misses 1234 1234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
force-pushed
the
jishnub/copytrito_quickreturn
branch
from
1f4f915 to
e902661
Compare
jishnub
force-pushed
the
jishnub/copytrito_quickreturn
branch
from
e902661 to
6bf623a
Compare
|
Gentle bump |
dkarrasch
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LAPACK function
lacpy!seems to handle aliasing correctly already, but since the LAPACK documentation doesn't expect the output arguments to be aliased, it's best if we carry out the unaliasing by ourselves.I've also added a quick return criterion if the two matrices are identical, in which case there is nothing to copy. This would be useful in copying elements between a triangular/symmetric matrix and its parent.