Skip to content

Fit broken matmul test #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Fit broken matmul test #1288

merged 2 commits into from
Apr 14, 2025

Conversation

andreasnoack
Copy link
Member

Since similar returns uninitialized memory, there is not reason to expect the two invocations to return the same values.

The broken test caused https://buildkite.com/julialang/linearalgebra-dot-jl/builds/517#0196337d-14ef-4846-be5c-85e92f72fd23/203-354

Since `similar` returns uninitialized memory, there is not reason to expect the two invocations to return the same values.
@andreasnoack andreasnoack requested a review from jishnub April 14, 2025 15:16
Copy link
Member

@jishnub jishnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this! I'd just suggest changing the zero(A) to copy(A), so that the scaling by beta is non-trivial

@andreasnoack
Copy link
Member Author

I'd just suggest changing the zero(A) to copy(A), so that the scaling by beta is non-trivial

Done in https://github.com/JuliaLang/LinearAlgebra.jl/pull/1288/commits

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (222f7f2) to head (4e4ac10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files          34       34              
  Lines       15499    15499              
==========================================
- Hits        14266    14265       -1     
- Misses       1233     1234       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 830ea2f into master Apr 14, 2025
3 of 4 checks passed
@jishnub jishnub deleted the andreasnoack-patch-1 branch April 14, 2025 17:31
@ViralBShah
Copy link
Member

Does this need backporting?

@jishnub
Copy link
Member

jishnub commented Apr 15, 2025

No, the test was added recently and isn't being backported, so the fix doesn't need backporting either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants