-
-
Notifications
You must be signed in to change notification settings - Fork 21
Fit broken matmul test #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit broken matmul test #1288
Conversation
Since `similar` returns uninitialized memory, there is not reason to expect the two invocations to return the same values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spotting this! I'd just suggest changing the zero(A)
to copy(A)
, so that the scaling by beta
is non-trivial
Done in https://github.com/JuliaLang/LinearAlgebra.jl/pull/1288/commits |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 34 34
Lines 15499 15499
==========================================
- Hits 14266 14265 -1
- Misses 1233 1234 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Does this need backporting? |
No, the test was added recently and isn't being backported, so the fix doesn't need backporting either. |
Since
similar
returns uninitialized memory, there is not reason to expect the two invocations to return the same values.The broken test caused https://buildkite.com/julialang/linearalgebra-dot-jl/builds/517#0196337d-14ef-4846-be5c-85e92f72fd23/203-354