Add context to errorshow except_str tests
#56199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
added
ci
Member
|
One testset per test seems overkill, but LGTM. We could also instead write this like we do in subtype.jl with the line number of the macro caller: |
Member
Author
|
Thanks for the suggestion! The error message becomes Test Failed at /home/jishnu/juliaPR/usr/share/julia/test/errorshow.jl:1099
Expression: typeof(err) === $(Expr(:escape, :MethodError))
Evaluated: StackOverflowError === MethodError
Context: expr = :(+())In principle, the context is redundant if the line number is displayed, but having it displayed doesn't hurt anyway. |
aviatesk
approved these changes
Oct 17, 2024
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
With this, the error message in https://buildkite.com/julialang/julia-master/builds/41054#019294ca-e2c5-41f2-a897-e2959715f154 would become ```julia Error in testset errorshow: Test Failed at /home/jishnu/juliaPR/usr/share/julia/test/errorshow.jl:226 Expression: typeof(err) === $(Expr(:escape, :MethodError)) Evaluated: StackOverflowError === MethodError Context: expr = :(+()) ``` Having the failing expression displayed makes it easier to locate the source of the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the error message in https://buildkite.com/julialang/julia-master/builds/41054#019294ca-e2c5-41f2-a897-e2959715f154 would become
Having the failing expression displayed makes it easier to locate the source of the error.