fix handling of unknown setting in @constprop, fix error message
#56946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
error handling
Member
Author
|
The current behavior is for |
nsajko
commented
Jan 4, 2025
aviatesk
reviewed
Jan 5, 2025
nsajko
commented
Jan 5, 2025
Co-authored-by: Shuhei Kadowaki <[email protected]>
nsajko
force-pushed
the
fix_constprop_error_handling
branch
from
2ab15ed to
30818e6
Compare
aviatesk
approved these changes
Jan 6, 2025
This was referenced Jan 28, 2025
Merged
Merged
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Feb 9, 2025
…uliaLang#56946) Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit a3f336f)
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Feb 9, 2025
…uliaLang#56946) Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit a3f336f)
This was referenced Feb 9, 2025
aviatesk
pushed a commit
that referenced
this pull request
Feb 10, 2025
…rror message (#57321) Backport of PR #56946 to v1.11. Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit a3f336f)
aviatesk
pushed a commit
that referenced
this pull request
Feb 10, 2025
…rror message (#57320) Backport of PR #56946 to v1.10. Co-authored-by: Shuhei Kadowaki <[email protected]> (cherry picked from commit a3f336f)
nsajko
removed
backport 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.