-
Notifications
You must be signed in to change notification settings - Fork 29
Regenerate LibCURL.jl via Clang.jl #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The |
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 20% 6.94% -13.06%
==========================================
Files 2 2
Lines 10 72 +62
==========================================
+ Hits 2 5 +3
- Misses 8 67 +59
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the ANONYMOUS constants were generated or if they are needed (in lc_common_h.jl).
Edit: They have now been deleted since they came from badly parsed enums.
There is one constant I'm not sure what to do with. It gets generated as const CURL_ZERO_TERMINATED = ((size_t) -1) but this errors in julia: julia> Csize_t(-1)
ERROR: InexactError: check_top_bit(Int64, -1)
Stacktrace:
[1] throw_inexacterror(::Symbol, ::Any, ::Int64) at ./boot.jl:567
[2] check_top_bit at ./boot.jl:581 [inlined]
[3] toUInt64 at ./boot.jl:692 [inlined]
[4] UInt64(::Int64) at ./boot.jl:722
[5] top-level scope at none:0 I have left the constant defined for now as: const CURL_ZERO_TERMINATED = -1 |
My other concern is that some things that used to be |
The C code probably wants to do: julia> reinterpret(Csize_t, -1)
0xffffffffffffffff |
I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor stylistic pedantry 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
@nicoleepp I assume you're good with squashing the commits? |
Travis also passed but seems to have not linked back to this PR |
I'm good with squashing |
Nice work here! |
The code used to regenerate is included in
gen/generate.jl
. Used Clang.jl on 0.7.Closes #52
LibCURL and FTPClient tests pass.
Version of CURL/LibCURL used: 7.61.1