Skip to content

tests/ssl: fix memcpy signature for 32-bit systems #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

StefanKarpinski
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #89 into master will increase coverage by 2.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage    7.51%   10.21%   +2.70%     
==========================================
  Files           2        2              
  Lines         133      137       +4     
==========================================
+ Hits           10       14       +4     
  Misses        123      123              
Impacted Files Coverage Δ
src/lC_curl_h.jl 6.45% <0.00%> (+2.31%) ⬆️
src/LibCURL.jl 46.15% <0.00%> (+4.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d018fe7...260fe36. Read the comment docs.

@StefanKarpinski
Copy link
Contributor Author

StefanKarpinski commented Sep 9, 2020

I'm going to merge this since it passes CI and it's an uncontroversial bugfix: the signature for memcpy is simply wrong on any 32-bit platform (and segfaults there).

@StefanKarpinski StefanKarpinski merged commit 70aa2cc into master Sep 9, 2020
@StefanKarpinski StefanKarpinski deleted the sk/fix32bit branch September 9, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants