tests: use Downloads.download instead of Base.download #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
reviewed
Sep 22, 2020
Base.download will be deprecated in Julia 1.6 but the Downloads package offers a consistent libcurl-based way to download instead.
StefanKarpinski
force-pushed
the
sk/test-use-Downloads
branch
from
a3c153b to
a34bbbe
Compare
|
The FreeBSD nightly hasn't been updated yet, but I'm going to declare victory on this since everything else is passing and FreeBSD will as soon as a new nightly Julia gets successfully built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.download will be deprecated in Julia 1.6 but the Downloads package
offers a consistent libcurl-based way to download instead.
Previous PR: #90