Skip to content

add CURLOPT_MAXAGE_CONN #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2021
Merged

add CURLOPT_MAXAGE_CONN #99

merged 1 commit into from
Mar 18, 2021

Conversation

tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented Mar 17, 2021

Added const for CURLOPT_MAXAGE_CONN definition and exported it.
Useful to control how curl reuses connections.

While the other most options for long lived connections are already present, connection maxage is also critical for cases where multiplexing is enabled. The default maxage of 118 seconds is often too less in such cases.

Also corrected CURLOPT_LASTENTRY to reflect the value as per v7.73 as used in LibCURL_jll at the moment.

Added const for `CURLOPT_MAXAGE_CONN` definition and exported it.
Useful to control how curl reuses connections.

While the other most options for long lived connections are already present, connection maxage is also critical for cases where multiplexing is enabled.
@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@tanmaykm
Copy link
Member Author

While I did try to regenerate the code, I faced the same issues as discussed here. This is just a const definition, and manual change should be safe at this point I believe.

@tanmaykm tanmaykm requested a review from quinnj March 17, 2021 09:46
@quinnj
Copy link
Member

quinnj commented Mar 17, 2021

SGTM

@tanmaykm tanmaykm merged commit 5c878c9 into master Mar 18, 2021
@tanmaykm tanmaykm deleted the tan/opts branch March 18, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants