Skip to content

🐛 Modules with Trailing Zeroes do not install correctly #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

🐛 Modules with Trailing Zeroes do not install correctly #99

merged 1 commit into from
Dec 6, 2024

Conversation

raandree
Copy link
Contributor

@raandree raandree commented Dec 3, 2024

Fixes #98

@JustinGrote
Copy link
Owner

JustinGrote commented Dec 3, 2024

Thanks for your submission!

This is a good start, but I really didn't want to touch disk to read the manifests after each install/update, for the times where someone is doing something like Az or whatnot and installing hundreds of modules. We probably want to at the very least add a -NoTrailingZeroModules switch or something to bypass this check if you know you're not using modules with trailing quad zero modules.

I also don't know if I currently handle the case for if a trailing zero module is already installed and a new trailing zero is existing, both the same version and an older version, so we'll need Pester tests to make sure those all work correctly.

@JustinGrote JustinGrote changed the title Fixes #98 🐛 Modules with Trailing Zeroes do not install correctly Dec 6, 2024
@JustinGrote JustinGrote merged commit 6676c61 into JustinGrote:fix/singleTrailingZero Dec 6, 2024
@JustinGrote
Copy link
Owner

@raandree oops I thought this merged into main, I'll get that done and get you credit.

JustinGrote added a commit that referenced this pull request Dec 6, 2024
@raandree
Copy link
Contributor Author

raandree commented Dec 7, 2024

I thought I should add something like a NoTrailingZeroModules switch first so it doesn't negatively affect performance. Should I still do that?

@raandree raandree deleted the fix/singleTrailingZero branch December 7, 2024 07:32
@JustinGrote
Copy link
Owner

JustinGrote commented Dec 7, 2024

I thought I should add something like a NoTrailingZeroModules switch first so it doesn't negatively affect performance. Should I still do that?

If you check, I did some updates to switch to just doing a raw parse of the .psd1 file that has way less overhead. Since it occurs at the end of installation and it's part of the parallel process, it's a very minimal overhead compared to doing a full parse of the psd, so I decided it wasn't necessary. My testing was like 5ms in most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants