Static pkg-config support #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue KhronosGroup#2117
Avoids having duplicate copies in both SPIRV_CROSS_STATIC and SPIRV_CROSS_SHARED if blocks
|
|
HansKristian-Work
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #2117 to the extent that a .pc file is created and installed for static builds.
I'm not sure if anything actually needs to be added to
Libs.privateorRequires.privateto align with @kasper93's comment aboutpkg-config --static, as there's nothing in my build notes indicating I'd ever had to mess with those fields after-the-fact. I was overly cautious about removing thesharedlibdirreferences in the static .pc.in template, so if those aren't needed, it's easy enough to remove them.