-
Notifications
You must be signed in to change notification settings - Fork 934
5.4 master fixes #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.4 master fixes #276
Conversation
Values are now encoded consistently by the formbuilder and the htmlbuilder
Figured it out. Thanks!
|
There's also a call in |
Could you already pull this in (tag is not necessary) so we can use this as a dependency for our packages? |
If you're desperate for something so you can test, I'm using this in my "repositories": [
{
"type": "vcs",
"url": "https://github.com/maddhatter/html.git"
}
],
"require": {
"laravelcollective/html": "5.4.x-dev",
} I'll probably go with that until a 5.4 branch is created on the main repo. |
Found another call to |
What would be the best way to combine the fixes on my fork with this PR? |
When i update to laravel 5.4 get: I use yajra/laravel-datatables-oracle and this package required laravelcollective/html |
As 5.4 is released, this issue starts to become more pressing. Not a big problem for dev environment yet, but it would be nice to know at least some ETA :) |
Hey all, sorry I've been swamped lately. I'm going to look over this tonight, and co-ordinate with @adamgoose I'll review the other packages as well |
Looking forward to this for my 5.4 app |
👍 |
Every day this takes longer, people will move away from this repo :-( If you don't have time @mlantz please allow another maintainer to test and make it 5.4 ready |
Changes have been supplied to you but still pending...? |
Still calling |
Fixing in #284 |
I added it to my package.json
run this
and it worked |
No description provided.