Skip to content

5.4 master fixes #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 26, 2017
Merged

5.4 master fixes #276

merged 8 commits into from
Jan 26, 2017

Conversation

Lazir
Copy link

@Lazir Lazir commented Jan 19, 2017

No description provided.

@yajra
Copy link
Contributor

yajra commented Jan 20, 2017

@Lazir do you have some idea on how I can test/use this PR on my app? I am currently testing Laravel 5.4 and updating my package with dependency on this. Thanks!

Figured it out. Thanks!

  • clone the repo
  • fetch pr
  • set composer repositories

@maddhatter
Copy link
Contributor

There's also a call in HtmlServiceProvider to getToken() that needs changed to token(). I made the change in my fork, here.

@freekmurze
Copy link

Could you already pull this in (tag is not necessary) so we can use this as a dependency for our packages?

@maddhatter
Copy link
Contributor

maddhatter commented Jan 23, 2017

If you're desperate for something so you can test, I'm using this in my composer.json:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/maddhatter/html.git"
        }
],
"require": {
     "laravelcollective/html": "5.4.x-dev",
}

I'll probably go with that until a 5.4 branch is created on the main repo.

@maddhatter
Copy link
Contributor

Found another call to getToken in FormBuilder: maddhatter@23223c6

@django23 django23 mentioned this pull request Jan 23, 2017
Closed
@maddhatter
Copy link
Contributor

What would be the best way to combine the fixes on my fork with this PR?

@michaloravec
Copy link

When i update to laravel 5.4 get:
Call to undefined method Illuminate\Foundation\Application::bindShared()

I use yajra/laravel-datatables-oracle and this package required laravelcollective/html

@laacz
Copy link

laacz commented Jan 24, 2017

As 5.4 is released, this issue starts to become more pressing. Not a big problem for dev environment yet, but it would be nice to know at least some ETA :)

@mlantz
Copy link
Member

mlantz commented Jan 25, 2017

Hey all, sorry I've been swamped lately. I'm going to look over this tonight, and co-ordinate with @adamgoose I'll review the other packages as well

@JordanDalton
Copy link

Looking forward to this for my 5.4 app

@OzanKurt
Copy link

👍

@webpatser
Copy link

Every day this takes longer, people will move away from this repo :-( If you don't have time @mlantz please allow another maintainer to test and make it 5.4 ready

@bbashy
Copy link

bbashy commented Jan 26, 2017

Changes have been supplied to you but still pending...?

@adamgoose adamgoose merged commit 86832de into LaravelCollective:master Jan 26, 2017
@dukadin
Copy link

dukadin commented Jan 26, 2017

Still calling getToken() in HtmlServiceProvider.

@adamgoose
Copy link
Member

Fixing in #284

@webfelipemaia
Copy link

I added it to my package.json

 require {
        "laravelcollective/html": "~5.0"
}

run this

composer update
composer dump-autoload -o

and it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.