Skip to content

refactor: Extract explorer cache related code #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2019
Merged

refactor: Extract explorer cache related code #301

merged 3 commits into from
May 7, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Apr 30, 2019

Resolve #299

The design is still open for discussion. But so far the implementation of the ExplorereDataProvider is much clear than before.

@jdneo jdneo added this to the 0.14.2 milestone Apr 30, 2019
@jdneo jdneo requested review from poppinlp and Vigilans April 30, 2019 07:10
Vigilans
Vigilans approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Being busy lately, I didn't pull and test it locally.
Tested without problem.

@jdneo jdneo merged commit e920316 into master May 7, 2019
@jdneo jdneo deleted the cs/cache branch May 7, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vigilans Vigilans Vigilans approved these changes

@poppinlp poppinlp Awaiting requested review from poppinlp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.2
Development

Successfully merging this pull request may close these issues.

Store problems cache in treeview
2 participants
@jdneo @Vigilans