Update gpCAM.py #1465
Open
Update gpCAM.py #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuds13
reviewed
Nov 26, 2024
| @@ -74,7 +74,7 @@ def ask_numpy(self, n_trials: int) -> npt.NDArray: | |||
| input_set=np.column_stack((self.lb, self.ub)), | |||
| n=n_trials, | |||
| pop_size=n_trials, | |||
| acquisition_function="total correlation", | |||
There was a problem hiding this comment.
This should prob be passed as option, with sensible default.
There was a problem hiding this comment.
For uncertainty reduction, the default "variance" simply finds N best points, but they may be close to each other. "total correlation" is more expensive but points found are self-avoiding, which is what we usually want.
But also there is "MINIMIZE", "MAXIMIZE" keywords, that I guess we need to incorporate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some small issues preventing tell in the generator standard