Skip to content

remove outdated documentation on arbitrary args #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bkcsfi
Copy link

@bkcsfi bkcsfi commented Mar 6, 2023

removed outdated docs regarding unknown params because that functionality was removed in an earlier version

Changed in version 0.11.0: Removed ability to pass arbitrary keyword arguments to set server settings. Added a dedicated parameter server_settings for that.

I'm sad this was removed, now its a lot more difficult to set tcp_keepalives using sqlalchemy.

removed outdated docs regarding unknown params because that functionality was removed in an earlier version

> Changed in version 0.11.0: Removed ability to pass arbitrary keyword arguments to set server settings. Added a dedicated parameter server_settings for that.

I'm sad this was removed, now its a lot more difficult to set tcp_keepalives using sqlalchemy.
@elprans
Copy link
Member

elprans commented Oct 9, 2023

That note is in reference to keyword arguments to connect(), NOT server parameters specified in the DSN query, those are still supported.

@elprans elprans closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants