allow setting statement name in set_type_codec
#1131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2024
This is necessary when using PgBouncer because otherwise the default simplistically-generated statement names can fight with other programs using asyncpg due to PgBouncer sharing the same underlying PostgreSQL connection and thus the prepared statement names. [Supposedly asyncpg can be made to use an unnamed statement here by turning the cache off][0], but I can't for the life of me figure out how to do that when using asyncpg through SQLAlchemy; I observe that setting `prepared_statement_cache_size` to `0` as described [here][1] doesn't cause `use_cache` to be `False`. Anyway, that's not really asyncpg's problem. I think this functionality should probably be provided either way since it'd be kinda weird to only allow configuring the names of *some* prepared statements. [0]: https://github.com/MagicStack/asyncpg/blob/1aab2094d82104d5eee2cffcfd0c7e7347d4c5b8/asyncpg/connection.py#L415-L424 [1]: https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#prepared-statement-cache
CobaltCause
force-pushed
the
set-type-codec-name
branch
from
f63c7a9 to
c266796
Compare
|
Closing this since it's been a while and I've since solved my problem by using psycopg3 instead, which supports disabling prepared statements altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when using PgBouncer because otherwise the default simplistically-generated statement names can fight with other programs using asyncpg due to PgBouncer sharing the same underlying PostgreSQL connection and thus the prepared statement names.
Supposedly asyncpg can be made to use an unnamed statement here by turning the cache off, but I can't for the life of me figure out how to do that when using asyncpg through SQLAlchemy; I observe that setting
prepared_statement_cache_sizeto0as described here doesn't causeuse_cacheto beFalse. Anyway, that's not really asyncpg's problem.I think this functionality should probably be provided either way since it'd be kinda weird to only allow configuring the names of some prepared statements.