atcacert_def.c: remove duplicate initialization of temp_buf_size #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Pijanowski <[email protected]>
|
Thank you for the report, however, this change introduces subtle bug. The atcacert_get_cert_sn() function actually modifies temp_buf_size to report the sn size. Without resetting the size, the size check later on will not be aware of the full size of temp_buf and may error out with ATCACERT_E_BUFFER_TOO_SMALL inappropriately. I have noted the extra initialization temp_buf_size and will add that fix to our next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maciej Pijanowski [email protected]