Skip to content

Fixed empty parameters, copyedits #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2019
Merged

Fixed empty parameters, copyedits #4517

merged 3 commits into from
Jul 5, 2019

Conversation

davidsmatlak
Copy link
Contributor

@davidsmatlak davidsmatlak commented Jul 3, 2019 •
edited by DCtheGeek
Loading

Version(s) of document impacted

  • Impacts 7 document
  • Impacts 6 document
  • Impacts 5.1 document
  • Impacts 5.0 document
  • Impacts 4.0 document
  • Impacts 3.0 document

Acrolinx scores
Save-Script: original version: 95, updated version: 98
Uninstall-Module: original version: 93, updated version: 97
Uninstall-Script: original version: 94, updated version: 97

@davidsmatlak davidsmatlak mentioned this pull request Jul 3, 2019
Closed
8 tasks
@opbld34
Copy link

opbld34 commented Jul 3, 2019

Docs Build status updates of commit d3857d2:

✅ Validation status: passed

File Status Preview URL Details
reference/5.0/PowershellGet/Save-Module.md ✅Succeeded View (powershell-5.0)
reference/5.0/PowershellGet/Uninstall-Module.md ✅Succeeded View (powershell-5.0)
reference/5.1/PowershellGet/Save-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/PowershellGet/Save-Script.md ✅Succeeded View (powershell-5.1)
reference/5.1/PowershellGet/Uninstall-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/PowershellGet/Uninstall-Script.md ✅Succeeded View (powershell-5.1)
reference/6/PowerShellGet/Save-Module.md ✅Succeeded View (powershell-6)
reference/6/PowerShellGet/Save-Script.md ✅Succeeded View (powershell-6)
reference/6/PowerShellGet/Uninstall-Module.md ✅Succeeded View (powershell-6)
reference/6/PowerShellGet/Uninstall-Script.md ✅Succeeded View (powershell-6)
reference/7/PowerShellGet/Save-Module.md ✅Succeeded View (powershell-7)
reference/7/PowerShellGet/Save-Script.md ✅Succeeded View (powershell-7)
reference/7/PowerShellGet/Uninstall-Module.md ✅Succeeded View (powershell-7)
reference/7/PowerShellGet/Uninstall-Script.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

sdwheeler
sdwheeler requested changes Jul 4, 2019
View reviewed changes
reference/5.0/PowershellGet/Uninstall-Module.md

## EXAMPLES

### Example 1: Get a module and uninstall it
### Example 1: Uninstall a module
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you want to change the example to not use the pipeline? It is a good use case. Also, we don't need to call Get-InstalledModule if we are not using the pipeline.

I think we need one example that is just a simple uninstall module by name. and one example using the pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial tests were incorrect because the pipeline didn't work, so I split the commands. I read your feedback and retested, and the pipeline tests were successful. I updated the examples.

reference/5.1/PowershellGet/Uninstall-Script.md Outdated
This example uninstalls a script from the local computer.

```powershell
Get-InstalledScript -Name UpdateManagement-Template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to call Get-InstalledScript if we are not using the pipeline. Think we should have a simple example to show uninstall by name and another to show using the pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I updated the examples.

reference/5.0/PowershellGet/Uninstall-Module.md Outdated
@@ -1,5 +1,5 @@
---
ms.date: 06/09/2017
ms.date: 7/2/2019
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date needs to be 07/02/2019. Need all the digits. Fix in all articles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I updated the date in each document.

@opbld34
Copy link

opbld34 commented Jul 5, 2019

Docs Build status updates of commit 3d9344f:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
reference/5.0/PowershellGet/Uninstall-Module.md ❌Error Details
reference/5.1/PowershellGet/Uninstall-Module.md ❌Error Details
reference/5.1/PowershellGet/Uninstall-Script.md ❌Error Details
reference/6/PowerShellGet/Uninstall-Module.md ❌Error Details
reference/6/PowerShellGet/Uninstall-Script.md ❌Error Details
reference/7/PowerShellGet/Uninstall-Module.md ❌Error Details
reference/7/PowerShellGet/Uninstall-Script.md ❌Error Details
❌Error Details
developer/cmdlet/creating-a-cmdlet-to-access-a-data-store.md ⚠️Warning Details

reference/5.0/PowershellGet/Uninstall-Module.md

  • [Error]
Failed to parse 5.0/PowershellGet/Uninstall-Module.md due to :190:(638) '`Uninstall-Module` accepts '
 Expect Heading, please use PlatyPS to do content validation

reference/5.1/PowershellGet/Uninstall-Module.md

  • [Error]
Failed to parse 5.1/PowershellGet/Uninstall-Module.md due to :225:(735) '`Uninstall-Module` accepts '
 Expect Heading, please use PlatyPS to do content validation

reference/5.1/PowershellGet/Uninstall-Script.md

  • [Error]
Failed to parse 5.1/PowershellGet/Uninstall-Script.md due to :205:(674) '`Uninstall-Script` accepts '
 Expect Heading, please use PlatyPS to do content validation

reference/6/PowerShellGet/Uninstall-Module.md

  • [Error]
Failed to parse 6/PowerShellGet/Uninstall-Module.md due to :225:(735) '`Uninstall-Module` accepts '
 Expect Heading, please use PlatyPS to do content validation

reference/6/PowerShellGet/Uninstall-Script.md

  • [Error]
Failed to parse 6/PowerShellGet/Uninstall-Script.md due to :205:(674) '`Uninstall-Script` accepts '
 Expect Heading, please use PlatyPS to do content validation

reference/7/PowerShellGet/Uninstall-Module.md

  • [Error]
Failed to parse 7/PowerShellGet/Uninstall-Module.md due to :225:(735) '`Uninstall-Module` accepts '
 Expect Heading, please use PlatyPS to do content validation

reference/7/PowerShellGet/Uninstall-Script.md

  • [Error]
Failed to parse 7/PowerShellGet/Uninstall-Script.md due to :205:(674) '`Uninstall-Script` accepts '
 Expect Heading, please use PlatyPS to do content validation

  • Line 138: [Error] W:\neno-s\.optemp\packages\opbuild.scripts.1.76.0\tools\opbuild\docset.prebuild.ps1 failed to execute

developer/cmdlet/creating-a-cmdlet-to-access-a-data-store.md

  • Line 376: [Warning] Illegal link: `<a href="#Defining-the-Cmdlet-Class">Building the Cmdlet</a>` -- missing bookmark. The file cmdlet/creating-a-cmdlet-to-access-a-data-store.md doesn't contain a bookmark named Defining-the-Cmdlet-Class.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld31
Copy link

opbld31 commented Jul 5, 2019

Docs Build status updates of commit f2a0e6e:

✅ Validation status: passed

File Status Preview URL Details
reference/5.0/PowershellGet/Save-Module.md ✅Succeeded View (powershell-5.0)
reference/5.0/PowershellGet/Uninstall-Module.md ✅Succeeded View (powershell-5.0)
reference/5.1/PowershellGet/Save-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/PowershellGet/Save-Script.md ✅Succeeded View (powershell-5.1)
reference/5.1/PowershellGet/Uninstall-Module.md ✅Succeeded View (powershell-5.1)
reference/5.1/PowershellGet/Uninstall-Script.md ✅Succeeded View (powershell-5.1)
reference/6/PowerShellGet/Save-Module.md ✅Succeeded View (powershell-6)
reference/6/PowerShellGet/Save-Script.md ✅Succeeded View (powershell-6)
reference/6/PowerShellGet/Uninstall-Module.md ✅Succeeded View (powershell-6)
reference/6/PowerShellGet/Uninstall-Script.md ✅Succeeded View (powershell-6)
reference/7/PowerShellGet/Save-Module.md ✅Succeeded View (powershell-7)
reference/7/PowerShellGet/Save-Script.md ✅Succeeded View (powershell-7)
reference/7/PowerShellGet/Uninstall-Module.md ✅Succeeded View (powershell-7)
reference/7/PowerShellGet/Uninstall-Script.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sdwheeler sdwheeler merged commit 7b646eb into MicrosoftDocs:staging Jul 5, 2019
@davidsmatlak davidsmatlak deleted the ds-3740fixparms branch July 12, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdwheeler sdwheeler sdwheeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidsmatlak @opbld34 @opbld31 @sdwheeler