A query using max() finds short term latency spikes #36746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For identifying a cause of missing or delayed heartbeat entries from multiple computers, using percentile may not be sensitive enough. Using max() can pull out those worst-case outliers.
|
@sbonds : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@sbonds I spoke to the engineering team who supports this article. They're okay with the comment but prefer not to have the additional example. If you can remove the example, I'll go ahead and sign off. |
I don't quite follow the logic of removing a specific example, since in my mind that significantly helps clarify a concept. However, there could be competing goals of which I'm unaware.
|
I've removed the example, even though it seems to me that this reduces the clarity of the overall message. |
|
@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
I resolved the merge conflict and will merge the PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For identifying a cause of missing or delayed heartbeat entries from multiple computers, using percentile may not be sensitive enough. Using max() can pull out those worst-case outliers.
This was created as a separate pull request from #36745 since it's more than a simple minor description fix.