Skip to content

Update setup-on-wsl2.md - nvm install --lts - typo correction #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update setup-on-wsl2.md - nvm install --lts - typo correction #2815

merged 1 commit into from
Jan 4, 2021

Conversation

bc1121
Copy link
Contributor

@bc1121 bc1121 commented Nov 17, 2020

From: https://github.com/nvm-sh/nvm
README.md

Long-term Support
Node has a schedule for long-term support (LTS) You can reference LTS versions in aliases and .nvmrc files with the notation lts/* for the latest LTS, and lts/argon for LTS releases from the "argon" line, for example. In addition, the following commands support LTS arguments:

nvm install --lts

From: https://github.com/nvm-sh/nvm
README.md

Long-term Support
Node has a schedule for long-term support (LTS) You can reference LTS versions in aliases and .nvmrc files with the notation lts/* for the latest LTS, and lts/argon for LTS releases from the "argon" line, for example. In addition, the following commands support LTS arguments:

nvm install --lts
@PRMerger12
Copy link
Contributor

@bc1121 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bc1121
Copy link
Contributor Author

bc1121 commented Nov 19, 2020

I noticed that you guys had it correct at one time and then changed it.
#2743

I agree that the syntax is confusing but the word node in this syntax actually represents the version completely in this context as does --lts.

--lts doesn't modify node here, it replaces it.

nvm install node # "node" is an alias for the latest version

https://github.com/nvm-sh/nvm#long-term-support

You can search
site:https://github.com/nvm-sh/nvm "node --lts"
and you won't get any results
however
site:https://github.com/nvm-sh/nvm "install --lts"
brings up 4 hits on that page

The obvious proof is that...
nvm install --lts #works
and
nvm install node --lts #doesn't work/fails

@bc1121
Copy link
Contributor Author

bc1121 commented Nov 19, 2020

PS: @ktoliver, What does the aq stand for in the "aq-pr-triaged" label?

@ktoliver
Copy link
Contributor

ktoliver commented Nov 19, 2020

PS: @ktoliver Kristine Toliver (Aquent LLC) Vendor, What does the aq stand for in the "aq-pr-triaged" label?

Hi @bc1121 aq refers to Aquent, the Microsoft vendor that does PR reviews/processing in this repo. We use the label for pull request queue management.

@ktoliver
Copy link
Contributor

@mattwojo - Could you review the proposed update to your article? Thanks.

@mattwojo
Copy link
Contributor

mattwojo commented Jan 4, 2021

Thanks @bc1121! 👍

@mattwojo mattwojo merged commit 3fafc6b into MicrosoftDocs:docs Jan 4, 2021
QuinnRadich pushed a commit that referenced this pull request Jul 13, 2022
…-updates-in-windev

Update .NET MAUI info on get-started and samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants