feat: remove flag argument #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Pringled
approved these changes
Apr 24, 2025
stephantul
merged commit b613033
into
add-quantization-for-from-sentence-transformers
5 of 6 checks passed
Pringled
added a commit
that referenced
this pull request
Apr 24, 2025
* Added quantization for from_sentence_transformers * Updates * feat: remove flag argument (#220) * feat: remove flag argument * fix typing * add future anns --------- Co-authored-by: Stephan Tulkens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the flag argument in the load function and moves the quantization business to another function.