Skip to content

Bump version number and update changelog for 0.18.1 #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

bagerard
Copy link
Collaborator

Hi @wojcikstefan @erdenezul , 0.18.0 suffered from a bug (#2082) and we need to release a 0.18.1 asap.

The bug only affects models with custom primary keys, let me know if you have suggestion to this.
I checked the other commits that were merged since 0.18.0 and it mainly update to docs or tests so it should be safe to include them in 0.18.1

Copy link
Member

@wojcikstefan wojcikstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being proactive about this regression @bagerard!

I've left some thoughts on #2082 – take a look at them please before merging this. Everything LGTM besides that. I've also scanned all the recent commits to double-check that we're not missing anything important in the changelog.

Changes in 0.18.1
=================
- Fix a bug introduced in 0.18.0 which was causing `.save()` to update all the fields
instead of updating only the modified fields. This gug only occurs when using custom pk #2082
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo (bug vs gug).

@bagerard bagerard merged commit e8dbd12 into MongoEngine:master Jun 18, 2019
@bagerard
Copy link
Collaborator Author

Thanks for the review. I applied the fixes, merged and created a v0.18.1 release

@bagerard bagerard deleted the release_0_18_1 branch January 3, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants