Skip to content

Change used module from 'command' to 'shell' to allow shell redirect #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

Donien
Copy link
Member

@Donien Donien commented Jun 30, 2023

Fix #198

This PR adjusts a task that used the command module with a command that wants to redirect output into a file.
This, however, is not possible since no actual shell is used, thus making that redirect impossible. The Ingest Pipelines were never created.
Changed the command module to the shell module.

@widhalmt
Copy link
Member

widhalmt commented Jul 3, 2023

Great find! Thanks. Let us know, when you're done so we can review it. Don't let yourself be let down by failing checks. That's more due to GitHub problems then the code.

@afeefghannam89 afeefghannam89 marked this pull request as ready for review July 5, 2023 15:18
@widhalmt widhalmt added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 1b48436 Aug 3, 2023
@widhalmt widhalmt deleted the fix/impossible-redirect-198 branch August 3, 2023 12:28
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2023
Fix #140 

Needs the fix of #198 (potentially fixed by #200)

This PR changes a few 'changed_when: false' statements to 'changed_when:
true' to better reflect actual changes being made.
Those tasks already check if e.g. passwords present differ from the ones
we request. Since those specific tasks are only run if we see the need
for a change, it should be safe to consider it a change if they do run.

---------

Co-authored-by: Thomas Widhalm <[email protected]>
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
…ETWAYS#200)

Fix NETWAYS#198

This PR adjusts a task that used the `command` module with a command
that wants to redirect output into a file.
This, however, is not possible since no actual shell is used, thus
making that redirect impossible. The Ingest Pipelines were never
created.
Changed the `command` module to the `shell` module.

Co-authored-by: Afeef Ghannam <[email protected]>
Co-authored-by: Thomas Widhalm <[email protected]>
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
Fix NETWAYS#140 

Needs the fix of NETWAYS#198 (potentially fixed by NETWAYS#200)

This PR changes a few 'changed_when: false' statements to 'changed_when:
true' to better reflect actual changes being made.
Those tasks already check if e.g. passwords present differ from the ones
we request. Since those specific tasks are only run if we see the need
for a change, it should be safe to consider it a change if they do run.

---------

Co-authored-by: Thomas Widhalm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspected bug: "Enable Ingest Pipelines" task not working due to impossible redirect
3 participants