Change used module from 'command' to 'shell' to allow shell redirect #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find! Thanks. Let us know, when you're done so we can review it. Don't let yourself be let down by failing checks. That's more due to GitHub problems then the code. |
afeefghannam89
approved these changes
Jul 5, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Fix #140 Needs the fix of #198 (potentially fixed by #200) This PR changes a few 'changed_when: false' statements to 'changed_when: true' to better reflect actual changes being made. Those tasks already check if e.g. passwords present differ from the ones we request. Since those specific tasks are only run if we see the need for a change, it should be safe to consider it a change if they do run. --------- Co-authored-by: Thomas Widhalm <[email protected]>
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
…ETWAYS#200) Fix NETWAYS#198 This PR adjusts a task that used the `command` module with a command that wants to redirect output into a file. This, however, is not possible since no actual shell is used, thus making that redirect impossible. The Ingest Pipelines were never created. Changed the `command` module to the `shell` module. Co-authored-by: Afeef Ghannam <[email protected]> Co-authored-by: Thomas Widhalm <[email protected]>
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
Fix NETWAYS#140 Needs the fix of NETWAYS#198 (potentially fixed by NETWAYS#200) This PR changes a few 'changed_when: false' statements to 'changed_when: true' to better reflect actual changes being made. Those tasks already check if e.g. passwords present differ from the ones we request. Since those specific tasks are only run if we see the need for a change, it should be safe to consider it a change if they do run. --------- Co-authored-by: Thomas Widhalm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #198
This PR adjusts a task that used the
commandmodule with a command that wants to redirect output into a file.This, however, is not possible since no actual shell is used, thus making that redirect impossible. The Ingest Pipelines were never created.
Changed the
commandmodule to theshellmodule.