Use a separate communicator for AMAX reduction #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erhoo82
force-pushed
the
slym/amax_proc_group
branch
2 times, most recently
from
1f83729 to
36017e8
Compare
erhoo82
changed the title
erhoo82
force-pushed
the
slym/amax_proc_group
branch
from
36017e8 to
7505295
Compare
crcrpar
reviewed
Feb 15, 2023
reflect suggestion
erhoo82
force-pushed
the
slym/amax_proc_group
branch
from
7505295 to
55a3d26
Compare
Contributor
Author
|
Thanks for the comments. I have applied the suggested changes. |
yuanzhedong
pushed a commit
to yuanzhedong/apex
that referenced
this pull request
Jul 14, 2023
* add amax reduction group for fp8 training * use a separate communicator for amax reduction across DP-ranks reflect suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable the overlap of AMAX reduction and the other DP-communications e.g. gradient reduction and parameter gathering.