Fix Kotlin enum accessing issue #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtrifonov
approved these changes
Dec 27, 2019
vmutafov
added a commit
that referenced
this pull request
Dec 30, 2019
* bumping version * fix(workers): Dispose the isolate when terminating workers (#1550) * fix: Ensure js timestamp is smaller than corresponding code cache file timestamp (#1554) * Fix Kotlin enum accessing issue (#1559) * Update package.json version to 6.3.1 * Update CHANGELOG.md Co-authored-by: Vasil Trifonov <[email protected]> Co-authored-by: Darin Dimitrov <[email protected]>
vmutafov
added a commit
that referenced
this pull request
Jan 31, 2020
* fix(workers): Dispose the isolate when terminating workers (#1550) * Prepare 6.3.1 patch (#1561) * bumping version * fix(workers): Dispose the isolate when terminating workers (#1550) * fix: Ensure js timestamp is smaller than corresponding code cache file timestamp (#1554) * Fix Kotlin enum accessing issue (#1559) * Update package.json version to 6.3.1 * Update CHANGELOG.md Co-authored-by: Vasil Trifonov <[email protected]> Co-authored-by: Darin Dimitrov <[email protected]> Co-authored-by: Darin Dimitrov <[email protected]> Co-authored-by: Vasil Trifonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1560
Due to a bug in the MDG, Kotlin enum entries couldn't be accessed through JS. This PR fixes this behavior and adds additional tests for the Kotlin support.