Skip to content

Update README.md highlighting dependency on sibling plugins #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

NicholasSmilovic
Copy link
Contributor

I don't believe it is currently communicated clearly that @nativescript/firebase-core cannot initialize successfully on it's own.

@nativescript/firebase-core initialization code

    const defaultApp = firebase().initializeApp().then(() => {
        console.warn('🔥 Firebase initialized');
      }).catch(error => {
        console.error('🔥 Firebase initialization error: ', error)
      });

fails on android with: Error: Cannot read properties of undefined (reading 'FirebaseApp')
fails on iOS with: Error: FIRApp is not defined

Installing plugin @nativescript/firebase-messaging, I assume any other would work too, makes the initialization a success

@cla-bot
Copy link

cla-bot bot commented May 12, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @NicholasSmilovic.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@NicholasSmilovic
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label May 12, 2023
@cla-bot
Copy link

cla-bot bot commented May 12, 2023

The cla-bot has been summoned, and re-checked this pull request!

@triniwiz triniwiz merged commit 357eb60 into NativeScript:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants