Fix assertion failure when setting the interpreter of a debug-only executable #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an assertion failure when 'lastReplaced' is followed by one or mo NOBITS sections, since they won't have a valid startOffset. Fixes: NixOS#373
|
Should we also bail out of Unfortunately auto-patchelf calls |
|
The test I added showed another problem when run with clang. It looks like clang outputs ET_DYN, which means it doesn't even hit the other fix in The problem with clang (with both old and new binutils) is that it's accessing .dynamic even if it's NOBITS. I've pushed a fix for that in ad3d3d4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included test currently fails only on binutils 2.44, which is available on
nixpkgs-unstable. I've only tested on x86_64-linux.Perhaps
lastReplacedshould be renamed because it no longer ends up pointing to the actual last replaced section.