Skip to content

Missed builtin, should be last one #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2018
Merged

Missed builtin, should be last one #138

merged 1 commit into from
Jan 5, 2018

Conversation

lsetiawan
Copy link
Member

Overview

Missed the builtins type in getCVs function. This should be the last ones, according to travis-CI.

@lsetiawan lsetiawan requested a review from emiliom January 5, 2018 23:05
@lsetiawan
Copy link
Member Author

This also addresses #115.

@emiliom
Copy link
Member

emiliom commented Jan 5, 2018

Missed the builtins type in getCVs function. This should be the last ones, according to travis-CI.

Do you mean the last type builtin, or the last builtin altogether (ie, no more misuse of builtins!)? If it's the latter, this PR will close #115

@lsetiawan
Copy link
Member Author

Give TravisCI another few minutes until flake8 test is done, and we will see if it's the last misused builtin. Thanks.

@emiliom emiliom merged commit b572e29 into ODM2:development Jan 5, 2018
@emiliom emiliom mentioned this pull request Jan 5, 2018
Closed
@lsetiawan lsetiawan deleted the fix_getcv branch January 5, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiliom emiliom emiliom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsetiawan @emiliom