Allow sfid to be None to work with older code #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this the documented behavior (eg, in the docstring)? It makes sense, but I can't remember. Is this the behavior in the last tagged release (so that the problem got introduced in the dev branch)? |
This behavior is documented in docstring. I introduced this when trying to place warnings and removing builtins, so I'm fixing it here. Thanks. |
|
Ok. Thanks for the clarification. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While working on the
odm2restapi, I noticed thatgetResultswas returning nothing whensfidisNone, so this should fix that andgetResultsshould return all results whensfidisNone.