Configurable incompatible checks - NumericRange

- See #550
- Makes configurable the enabling/disabling of this incompatibility check (disabled by default to avoid a breaking change)

core/src/main/java/org/openapitools/openapidiff/core/model/BackwardIncompatibleProp.java

@@ -12,10 +12,12 @@ public enum BackwardIncompatibleProp {
   REQUEST_CONTENT_DECREASED("incompatible.request.content.decreased", true),
   REQUEST_ENUM_DECREASED("incompatible.request.enum.decreased", true),
   REQUEST_MAX_LENGTH_DECREASED("incompatible.request.max.length.decreased", true),
+  REQUEST_NUMERIC_RANGE_DECREASED("incompatible.request.numeric.range.decreased", true),
   REQUEST_REQUIRED_INCREASED("incompatible.request.required.increased", true),
   RESPONSE_CONTENT_DECREASED("incompatible.response.content.decreased", true),
   RESPONSE_ENUM_INCREASED("incompatible.response.enum.increased", true),
   RESPONSE_MAX_LENGTH_INCREASED("incompatible.response.max.length.increased", true),
+  RESPONSE_NUMERIC_RANGE_INCREASED("incompatible.response.numeric.range.increased", false),
   RESPONSE_REQUIRED_DECREASED("incompatible.response.required.decreased", true),
   RESPONSE_RESPONSES_DECREASED("incompatible.response.responses.decreased", true),
   SCHEMA_DISCRIMINATOR_CHANGED("incompatible.schema.discriminator.changed", true),

core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedNumericRange.java

@@ -1,5 +1,8 @@
 package org.openapitools.openapidiff.core.model.schema;
 
+import static org.openapitools.openapidiff.core.model.BackwardIncompatibleProp.REQUEST_NUMERIC_RANGE_DECREASED;
+import static org.openapitools.openapidiff.core.model.BackwardIncompatibleProp.RESPONSE_NUMERIC_RANGE_INCREASED;
+
 import java.math.BigDecimal;
 import java.util.Objects;
 import org.openapitools.openapidiff.core.model.Changed;
@@ -26,6 +29,11 @@ public DiffResult isChanged() {
       return DiffResult.NO_CHANGES;
     }
 
+    if ((context.isRequest() && !REQUEST_NUMERIC_RANGE_DECREASED.enabled(context))
+        || (context.isResponse() && !RESPONSE_NUMERIC_RANGE_INCREASED.enabled(context))) {
+      return DiffResult.COMPATIBLE;
+    }
+
     boolean exclusiveMaxOld = oldMaximumExclusiveValue != null && oldMaximumExclusiveValue;
     boolean exclusiveMinOld = oldMinimumExclusiveValue != null && oldMinimumExclusiveValue;
     boolean exclusiveMaxNew = newMaximumExclusiveValue != null && newMaximumExclusiveValue;

core/src/test/java/org/openapitools/openapidiff/core/backcompat/NumericRangeBCTest.java

@@ -1,8 +1,10 @@
 package org.openapitools.openapidiff.core.backcompat;
 
-import static org.openapitools.openapidiff.core.TestUtils.assertOpenApiBackwardIncompatible;
 import static org.openapitools.openapidiff.core.TestUtils.assertSpecChangedButCompatible;
+import static org.openapitools.openapidiff.core.TestUtils.assertSpecIncompatible;
 import static org.openapitools.openapidiff.core.TestUtils.assertSpecUnchanged;
+import static org.openapitools.openapidiff.core.model.BackwardIncompatibleProp.REQUEST_NUMERIC_RANGE_DECREASED;
+import static org.openapitools.openapidiff.core.model.BackwardIncompatibleProp.RESPONSE_NUMERIC_RANGE_INCREASED;
 
 import org.junit.jupiter.api.Test;
 
@@ -21,81 +23,89 @@ public void changedButCompatible() {
 
   @Test
   public void requestExclusiveMaxCreated() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_exclusive_max_created.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_exclusive_max_created.yaml");
   }
 
   @Test
   public void requestExclusiveMaxSet() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_exclusive_max_set.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_exclusive_max_set.yaml");
   }
 
   @Test
   public void requestExclusiveMinCreated() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_exclusive_min_created.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_exclusive_min_created.yaml");
   }
 
   @Test
   public void requestExclusiveMinSet() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_exclusive_min_set.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_exclusive_min_set.yaml");
   }
 
   @Test
   public void requestMaxAdded() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_max_added.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_max_added.yaml");
   }
 
   @Test
   public void requestMaxDecreased() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_max_decreased.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_max_decreased.yaml");
   }
 
   @Test
   public void requestMinAdded() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_min_added.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_min_added.yaml");
   }
 
   @Test
   public void requestMinIncreased() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_request_numericrange_min_increased.yaml");
+    assertIncompatibleRequest("bc_request_numericrange_min_increased.yaml");
   }
 
   @Test
   public void responseExclusiveMaxDeleted() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_exclusive_max_deleted.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_exclusive_max_deleted.yaml");
   }
 
   @Test
   public void responseExclusiveMaxUnset() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_exclusive_max_unset.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_exclusive_max_unset.yaml");
   }
 
   @Test
   public void responseExclusiveMinDeleted() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_exclusive_min_deleted.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_exclusive_min_deleted.yaml");
   }
 
   @Test
   public void responseExclusiveMinUnset() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_exclusive_min_unset.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_exclusive_min_unset.yaml");
   }
 
   @Test
   public void responseMaxDeleted() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_max_deleted.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_max_deleted.yaml");
   }
 
   @Test
   public void responseMaxIncreased() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_max_increased.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_max_increased.yaml");
   }
 
   @Test
   public void responseMinDecreased() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_min_decreased.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_min_decreased.yaml");
   }
 
   @Test
   public void responseMinDeleted() {
-    assertOpenApiBackwardIncompatible(BASE, "bc_response_numericrange_min_deleted.yaml");
+    assertIncompatibleResponse("bc_response_numericrange_min_deleted.yaml");
+  }
+
+  private void assertIncompatibleRequest(String newSpec) {
+    assertSpecIncompatible(BASE, newSpec, REQUEST_NUMERIC_RANGE_DECREASED);
+  }
+
+  private void assertIncompatibleResponse(String newSpec) {
+    assertSpecIncompatible(BASE, newSpec, RESPONSE_NUMERIC_RANGE_INCREASED);
   }
 }