-
Notifications
You must be signed in to change notification settings - Fork 72
V1.13 Firmware updates #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ClutchplateDude
commented
Feb 17, 2024
- Ported some bug fix code from the LCD branch (e.g. track on boot)
- Potentially some DEC guide issues were fixed.
- Inadvertently removed some default #defines. Put them back.
- Allow new stepper lib to be enabled by via #define
- Added ability to detect new firmware flashed
- Removed/disabled parking offset variable and commands, use home offset instead
- Fixed Park command to slew home and then to the parking position (home offset)
- Re-integrated old stepper library
- Sped up ESP32 stepper code.
Testing stepper libs
- Added ability to detect new firmware flashed - Removed/disabled parking offset variable and commands, use home offset instead - Fixed Park command to slew home and then to the parking position (home offset)
- Added ability to switch between old and new stepper lib in config file using #define NEW_STEPPER_LIB.
- Fixed incorrect DEC target calculation for manual slewing. - Set default DEC limits for OAM.
- Inadvertantly removed some default #defines. Put them back.
# Conflicts: # Changelog.md # Configuration_adv.hpp # Version.h # src/MeadeCommandProcessor.cpp
- Track on boot from LCD bug fix. - DEC Guiding may have been misconfigured during parking and after slew to home (if guiding and slewing used different microsteps).
- Sped up ESP32 stepper code. - Re-instate some defines that were inadvertantly removed.
Looks like your PR has code that needs to be changed in order to meet our coding standards!
|
julianneswinoga
requested changes
Feb 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor stuff, thanks for the work :)
Addressed PR feedback and set version to V1.13.0
julianneswinoga
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.