Skip to content

Conversation

ClutchplateDude
Copy link
Member

  • Ported some bug fix code from the LCD branch (e.g. track on boot)
  • Potentially some DEC guide issues were fixed.
  • Inadvertently removed some default #defines. Put them back.
  • Allow new stepper lib to be enabled by via #define
  • Added ability to detect new firmware flashed
  • Removed/disabled parking offset variable and commands, use home offset instead
  • Fixed Park command to slew home and then to the parking position (home offset)
  • Re-integrated old stepper library
  • Sped up ESP32 stepper code.

Testing stepper libs
Move hemisphere config to later in boot sequence
- Added ability to detect new firmware flashed
- Removed/disabled parking offset variable and commands, use home offset instead
- Fixed Park command to slew home and then to the parking position (home offset)
- Added ability to switch between old and new stepper lib in config file using #define NEW_STEPPER_LIB.
- Fixed incorrect DEC target calculation for manual slewing.
- Set default DEC limits for OAM.
- Inadvertantly removed some default #defines. Put them back.
# Conflicts:
#	Changelog.md
#	Configuration_adv.hpp
#	Version.h
#	src/MeadeCommandProcessor.cpp
- Track on boot from LCD bug fix.
- DEC Guiding may have been misconfigured during parking and after slew to home (if guiding and slewing used different microsteps).
- Sped up ESP32 stepper code.
- Re-instate some defines that were inadvertantly removed.
- Removed COM Port definitions from platformio.ini
@openastrotech-bot
Copy link
Contributor

Looks like your PR has code that needs to be changed in order to meet our coding standards!
Here are your options:

  1. Apply the patch that was generated by the job
    1. Click details under the failing clang-format check
    2. Click the Artifacts dropdown in the top right
    3. Download + unzip the clang-format-diff.patch file into the OpenAstroTracker-Firmware repo
    4. Run git apply clang-format-diff.patch to make the changes
    5. Commit and push up the formatted code
  2. Run clang-format locally
    1. Run the command bash -c 'shopt -s nullglob globstar;GLOBIGNORE=./src/libs/TimerInterrupt/*; for i in ./{.,src/**,unit_tests,boards/**}/*.{c,cpp,h,hpp}; do clang-format -i $i; done'
    2. Commit and push up the formatted code

Copy link
Member

@julianneswinoga julianneswinoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff, thanks for the work :)

Addressed PR feedback and set version to V1.13.0
@ClutchplateDude ClutchplateDude merged commit ea731a0 into develop Feb 17, 2024
@ClutchplateDude ClutchplateDude deleted the old-stepper-lib-in-12 branch February 17, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants