Skip to content

Conversation

@ConorMacBride
Copy link
Member

@ConorMacBride ConorMacBride commented Apr 7, 2022

There must be only one wheel and it must be pure Python.

The test will have to be removed before merging as it causes CI to error.

Closes #2

There must be only one wheel and it must be pure Python.
@ConorMacBride ConorMacBride force-pushed the verify-pure-python branch 2 times, most recently from a5fe5e9 to a6b6e80 Compare April 7, 2022 17:29
@ConorMacBride
Copy link
Member Author

I'll need to delete the second commit, but you can see the error message here: https://github.com/OpenAstronomy/build-python-dist/actions/runs/2110548117

Copy link
Contributor

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Feel free to merge after removing the second commit.

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cadair Cadair merged commit bbb0e1c into OpenAstronomy:main Apr 8, 2022
@ConorMacBride ConorMacBride deleted the verify-pure-python branch April 8, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have a way of making sure the wheel build is only for pure-Python packages

3 participants