rename installed binaries to avoid name clashes and add manpages #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Bourdaud <[email protected]>
This prefix is added to avoid name clashes with other binaries installed on the system. Signed-off-by: Nicolas Bourdaud <[email protected]>
Signed-off-by: Nicolas Bourdaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 older commits:
The names of the installed binaries are very generic which can clash with names of other executables installed on the system. In particular 'record' for fakenect is provided by other packages on Debian and Ubuntu. In order to avoid this problem, the installable demos have all been prefixed with 'freenect-' and record has been renamed into fakenect-record.
I believe these changes are harmless but please modify or reject them if there are any issues. However this renames are applied since a long time in Debian and Ubuntu packages so I believe it would be nice that libfreenect integrate them.
The more recent commit:
This commit adds manpages to fakenect executables. If the two previous are rejected, you can cherry-pick this one anyway by renaming 'fakenect-record' into 'record' (the substitution must be done also in the manpage)