Fix include of libusb.h in wrappers/cpp/libfreenect.hpp #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise fails to build on systems with libusb.h provided outside of versioned directory, e.g. on kFreeBSD. This "bug" was introduced after initial changes of similar kind in e.g. 713c715 and 8219750 Signed-off-by: Yaroslav Halchenko <[email protected]>
|
This should be OK to merge because consumers of the header-only cpp wrapper will need to set up their own include directories anyway. |
piedar
added a commit
that referenced
this pull request
Jan 18, 2014
Fix include of libusb.h in wrappers/cpp/libfreenect.hpp (@yarikoptic) Reviewed-by: Benn Snyder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise fails to build on systems with libusb.h provided outside of versioned
directory, e.g. on kFreeBSD. This "bug" was introduced after initial
changes of similar kind in e.g. 713c715 and 8219750
Signed-off-by: Yaroslav Halchenko [email protected]